Skip to content

list: Emit per-change forge checks via --cr-checks JSON flag#1268

Open
ed-irl wants to merge 3 commits into
ed-irl/checks-bitbucketfrom
ed-irl/checks-list
Open

list: Emit per-change forge checks via --cr-checks JSON flag#1268
ed-irl wants to merge 3 commits into
ed-irl/checks-bitbucketfrom
ed-irl/checks-list

Conversation

@ed-irl

@ed-irl ed-irl commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

Wires the per-change checks data from each forge into 'gs log
--json' so the extension and other tooling can consume rolled-up
state and per-run detail.

  • internal/handler/list: new IncludeChecks flag in the request
    bitmask; new Checks field on BranchItem; batch-loaded via
    Repository.ChecksByChange alongside change state and comment
    counts in the existing errgroup.
  • log.go: new --cr-checks/spice.log.crChecks flag (negatable,
    default false) on commit log / commit log long. Honored by
    the JSON presenter; the graph presenter ignores it for now
    (UI surface lives in the extension per ext Idea: Local Merge Queue #65).
  • JSON schema: change objects gain an optional 'checks' field
    with {rollup, runs[], url}, mirroring the spec at ext WIP: Revert "restack: Don't use fork point if base hash is up to date" #100.
    Rollup is one of pending/passed/failed/none; runs[] preserves
    forge-native state strings.
  • testdata/script/log_checks.txt: end-to-end script covering
    failed/passed/none rollup states, per-run detail, --no-cr-checks
    omission, and the spice.log.crChecks config path.

Tracks irl-llc/git-spice-code-extension#100.

ed-irl and others added 2 commits June 23, 2026 20:41
Wires the per-change checks data from each forge into 'gs log
--json' so the extension and other tooling can consume rolled-up
state and per-run detail.

  - internal/handler/list: new IncludeChecks flag in the request
    bitmask; new Checks field on BranchItem; batch-loaded via
    Repository.ChecksByChange alongside change state and comment
    counts in the existing errgroup.
  - log.go: new --cr-checks/spice.log.crChecks flag (negatable,
    default false) on commit log / commit log long. Honored by
    the JSON presenter; the graph presenter ignores it for now
    (UI surface lives in the extension per ext #65).
  - JSON schema: change objects gain an optional 'checks' field
    with {rollup, runs[], url}, mirroring the spec at ext #100.
    Rollup is one of pending/passed/failed/none; runs[] preserves
    forge-native state strings.
  - testdata/script/log_checks.txt: end-to-end script covering
    failed/passed/none rollup states, per-run detail, --no-cr-checks
    omission, and the spice.log.crChecks config path.

Tracks irl-llc/git-spice-code-extension#100.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant